Re: [PATCH net] af_unix: take receive queue lock while appending new skb

2015-11-17 Thread Eric Dumazet
On Tue, 2015-11-17 at 15:55 +0100, Hannes Frederic Sowa wrote: > I want to move to unix_state_lock and completely drop sk_buff_head.lock > in af_unix, as such I would prefer to keep it this way as in some other > places in af_unix.c (e.g. unix_stream_connect). > > Or do you have a strong opinion

Re: [PATCH net] af_unix: take receive queue lock while appending new skb

2015-11-17 Thread Hannes Frederic Sowa
Hi Eric, On Tue, Nov 17, 2015, at 15:42, Eric Dumazet wrote: > On Tue, 2015-11-17 at 15:10 +0100, Hannes Frederic Sowa wrote: > > While possibly in future we don't necessarily need to use > > sk_buff_head.lock this is a rather larger change, as it affects the > > af_unix fd garbage collector,

Re: [PATCH net] af_unix: take receive queue lock while appending new skb

2015-11-17 Thread Eric Dumazet
On Tue, 2015-11-17 at 15:10 +0100, Hannes Frederic Sowa wrote: > While possibly in future we don't necessarily need to use > sk_buff_head.lock this is a rather larger change, as it affects the > af_unix fd garbage collector, diag and socket cleanups. This is too much > for a stable patch. > > For

[PATCH net] af_unix: take receive queue lock while appending new skb

2015-11-17 Thread Hannes Frederic Sowa
While possibly in future we don't necessarily need to use sk_buff_head.lock this is a rather larger change, as it affects the af_unix fd garbage collector, diag and socket cleanups. This is too much for a stable patch. For the time being grab sk_buff_head.lock without disabling bh and irqs, so

Re: [PATCH net] af_unix: take receive queue lock while appending new skb

2015-11-17 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 17 Nov 2015 15:10:59 +0100 > While possibly in future we don't necessarily need to use > sk_buff_head.lock this is a rather larger change, as it affects the > af_unix fd garbage collector, diag and socket cleanups. This is too