[PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

atl1c driver is doing order-4 allocation with GFP_ATOMIC priority. That often breaks networking after resume. Switch to GFP_KERNEL. Still not ideal, but should be significantly better. atl1c_setup_ring_resources() is called from .open() function, and already uses GFP_KERNEL, so this change is

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

> >>if (unlikely(!ring_header->desc)) { > >> - dev_err(>dev, "pci_alloc_consistend failed\n"); > >> + dev_err(>dev, "could not get memory for DMA buffer\n"); > >>goto err_nomem; > >>} > >>memset(ring_header->desc, 0, ring_header->size); > >> > >> > > >

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

From: Pavel Machek Date: Fri, 4 Dec 2015 09:11:27 +0100 >> >> if (unlikely(!ring_header->desc)) { >> >> - dev_err(>dev, "pci_alloc_consistend failed\n"); >> >> + dev_err(>dev, "could not get memory for DMA buffer\n"); >> >> goto err_nomem; >> >> } >>

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

From: Pavel Machek Date: Fri, 4 Dec 2015 22:30:27 +0100 > On Fri 2015-12-04 11:21:40, David Miller wrote: >> From: Pavel Machek >> Date: Fri, 4 Dec 2015 09:11:27 +0100 >> >> >> >>if (unlikely(!ring_header->desc)) { >> >> >> - dev_err(>dev,

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

On Fri 2015-12-04 11:21:40, David Miller wrote: > From: Pavel Machek > Date: Fri, 4 Dec 2015 09:11:27 +0100 > > >> >> if (unlikely(!ring_header->desc)) { > >> >> - dev_err(>dev, "pci_alloc_consistend failed\n"); > >> >> + dev_err(>dev, "could not

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

On Thu, 2015-12-03 at 16:59 +0100, Pavel Machek wrote: > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. > > atl1c_setup_ring_resources() is called from

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

From: Eric Dumazet Date: Thu, 03 Dec 2015 09:17:28 -0800 > On Thu, 2015-12-03 at 16:59 +0100, Pavel Machek wrote: >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal,

[PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

atl1c driver is doing order-4 allocation with GFP_ATOMIC priority. That often breaks networking after resume. Switch to GFP_KERNEL. Still not ideal, but should be significantly better. atl1c_setup_ring_resources() is called from .open() function, and already uses GFP_KERNEL, so this change is

Re: [PATCH net] atl1c: Improve driver not to do order 4 GFP_ATOMIC allocation

On Thu 03-12-15 16:59:05, Pavel Machek wrote: > > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. > > atl1c_setup_ring_resources() is called from .open()