Re: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-05 Thread David Miller
From: Michal Schmidt Date: Fri, 3 Jun 2016 15:32:18 +0200 > Since implementing VLAN filtering in commit 05cc5a39ddb74 > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN while > the interface is down: > > # ip link add link enp3s0f0 enp3s0f0_10 type vlan

RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-05 Thread Yuval Mintz
> > Since implementing VLAN filtering in commit 05cc5a39ddb74 > > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN > > while the interface is down. > > Hi Michal - thanks; I'll review this one on Sunday. I'm a bit worried about the fact we're hiding actual issues - E.g., if for

RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-03 Thread Yuval Mintz
> Since implementing VLAN filtering in commit 05cc5a39ddb74 > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN while the > interface is down. Hi Michal - thanks; I'll review this one on Sunday.

[PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-03 Thread Michal Schmidt
Since implementing VLAN filtering in commit 05cc5a39ddb74 ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN while the interface is down: # ip link add link enp3s0f0 enp3s0f0_10 type vlan id 10 RTNETLINK answers: Bad address and in dmesg (with bnx2x.debug=0x20): bnx2x: