Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Michal Hocko
On Wed 14-02-18 18:34:51, Jesper Dangaard Brouer wrote: > On Wed, 14 Feb 2018 16:06:40 +0100 > Michal Hocko wrote: > > > On Wed 14-02-18 22:17:34, Jason Wang wrote: > > > There're several implications after commit 0bf7800f1799 ("ptr_ring: > > > try vmalloc() when kmalloc() fails") with the using

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 06:04 PM, Michael S. Tsirkin wrote: > On Wed, Feb 14, 2018 at 10:17:34PM +0800, Jason Wang wrote: >> There're several implications after commit 0bf7800f1799 ("ptr_ring: >> try vmalloc() when kmalloc() fails") with the using of vmalloc() since >> can't allow GFP_ATOMIC but mandate GFP_

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Jesper Dangaard Brouer
On Wed, 14 Feb 2018 16:06:40 +0100 Michal Hocko wrote: > On Wed 14-02-18 22:17:34, Jason Wang wrote: > > There're several implications after commit 0bf7800f1799 ("ptr_ring: > > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > > can't allow GFP_ATOMIC but mandate GFP_KERNEL

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Michael S. Tsirkin
On Wed, Feb 14, 2018 at 10:17:34PM +0800, Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to cal

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Michal Hocko
On Wed 14-02-18 22:17:34, Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to call with GFP_ATOMI

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Daniel Borkmann
On 02/14/2018 03:17 PM, Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to call with GFP_ATOMIC.

Re: [PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Jesper Dangaard Brouer
On Wed, 14 Feb 2018 22:17:34 +0800 Jason Wang wrote: > There're several implications after commit 0bf7800f1799 ("ptr_ring: > try vmalloc() when kmalloc() fails") with the using of vmalloc() since > can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN > since cpumap try to call wit

[PATCH net] bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 Thread Jason Wang
There're several implications after commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails") with the using of vmalloc() since can't allow GFP_ATOMIC but mandate GFP_KERNEL. This will lead a WARN since cpumap try to call with GFP_ATOMIC. Fortunately, entry allocation of cpumap can only