Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-28 Thread David Miller
From: Date: Thu, 25 Jun 2015 16:50:13 +0300 > From: Gilad Ben-Yossef > > DSA master netdev promiscuity counter was not being properly > decremented on slave device open error path. > > Signed-off-by: Gilad Ben-Yossef Applied. -- To unsubscribe from this list: send the line "unsubscribe netde

Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-28 Thread Andrew Lunn
> It has occurred to me that dev_set_promiscuity() and its brethren > dev_set_allmulti() may not be the best of interfaces: > > - On cursory inspection of code using these function their name > implies the value of the relevant counter is set to the value passed > as parameter, not incremented by

Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-28 Thread Gilad Ben-Yossef
On Fri, Jun 26, 2015 at 6:04 PM, Andrew Lunn wrote: > On Thu, Jun 25, 2015 at 04:50:13PM +0300, gil...@ezchip.com wrote: >> From: Gilad Ben-Yossef >> >> DSA master netdev promiscuity counter was not being properly >> decremented on slave device open error path. >> ... > Acked-by: Andrew Lunn T

Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-26 Thread Florian Fainelli
On 25/06/15 06:50, gil...@ezchip.com wrote: > From: Gilad Ben-Yossef > > DSA master netdev promiscuity counter was not being properly > decremented on slave device open error path. > > Signed-off-by: Gilad Ben-Yossef > CC: Gilad Ben-Yossef > CC: David S. Miller > CC: Florian Fainelli > CC: G

Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-26 Thread Andrew Lunn
On Thu, Jun 25, 2015 at 04:50:13PM +0300, gil...@ezchip.com wrote: > From: Gilad Ben-Yossef > > DSA master netdev promiscuity counter was not being properly > decremented on slave device open error path. > > Signed-off-by: Gilad Ben-Yossef > CC: Gilad Ben-Yossef > CC: David S. Miller > CC: Fl

[PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-25 Thread giladb
From: Gilad Ben-Yossef DSA master netdev promiscuity counter was not being properly decremented on slave device open error path. Signed-off-by: Gilad Ben-Yossef CC: Gilad Ben-Yossef CC: David S. Miller CC: Florian Fainelli CC: Guenter Roeck CC: Andrew Lunn CC: Scott Feldman --- net/dsa/s

[PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-25 Thread Gilad Ben-Yossef
DSA master netdev promiscuity counter was not being properly decremented on slave device open error path. Signed-off-by: Gilad Ben-Yossef CC: Gilad Ben-Yossef CC: David S. Miller CC: Florian Fainelli CC: Guenter Roeck CC: Andrew Lunn CC: Scott Feldman --- net/dsa/slave.c |2 +- 1 files