Re: [PATCH net] ipvlan: fix various issues in ipvlan_process_multicast()

2016-12-21 Thread Eric Dumazet
On Wed, 2016-12-21 at 14:21 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > > > Thank you Eric for all these fixes. Thanks Mahesh. I will send a V2 to include this part as well : diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index

Re: [PATCH net] ipvlan: fix various issues in ipvlan_process_multicast()

2016-12-21 Thread महेश बंडेवार
On Wed, Dec 21, 2016 at 1:30 PM, Eric Dumazet wrote: > From: Eric Dumazet > > 1) netif_rx() / dev_forward_skb() should not be called from process > context. > > 2) ipvlan_count_rx() should be called with preemption disabled. > > 3) We should check if

[PATCH net] ipvlan: fix various issues in ipvlan_process_multicast()

2016-12-21 Thread Eric Dumazet
From: Eric Dumazet 1) netif_rx() / dev_forward_skb() should not be called from process context. 2) ipvlan_count_rx() should be called with preemption disabled. 3) We should check if ipvlan->dev is up before feeding packets to netif_rx() 4) We need to prevent device from