Re: [PATCH net] l2tp: fix {pppol2tp,l2tp_dfs}_seq_stop() in case of seq_file overflow

2018-04-22 Thread David Miller
From: Guillaume Nault Date: Thu, 19 Apr 2018 16:20:48 +0200 > Commit 0e0c3fee3a59 ("l2tp: hold reference on tunnels printed in pppol2tp > proc file") > assumed that if pppol2tp_seq_stop() was called with non-NULL private > data (the 'v' pointer), then pppol2tp_seq_start()

[PATCH net] l2tp: fix {pppol2tp,l2tp_dfs}_seq_stop() in case of seq_file overflow

2018-04-19 Thread Guillaume Nault
Commit 0e0c3fee3a59 ("l2tp: hold reference on tunnels printed in pppol2tp proc file") assumed that if pppol2tp_seq_stop() was called with non-NULL private data (the 'v' pointer), then pppol2tp_seq_start() would not be called again. It turns out that this isn't guaranteed, and overflowing the