Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-29 Thread David Miller
From: Ido Schimmel Date: Sun, 27 May 2018 09:48:41 +0300 > From: Petr Machata > > VLAN 1 is internally used for untagged traffic. Prevent creation of > explicit netdevice for that VLAN, because that currently isn't supported > and leads to the NULL pointer dereference cited below. > > Fix by

Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-28 Thread Petr Machata
Ido Schimmel writes: > On Mon, May 28, 2018 at 05:55:58AM +0200, Andrew Lunn wrote: >> > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c >> > b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c >> > index ca38a30fbe91..adc6ab2cf429 100644 >> > ---

Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-28 Thread Ido Schimmel
On Mon, May 28, 2018 at 05:55:58AM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > index ca38a30fbe91..adc6ab2cf429 100644 > > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > > +++

Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-27 Thread Andrew Lunn
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > index ca38a30fbe91..adc6ab2cf429 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c > @@ -4433,6 +4433,11 @@ static

Re: [PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-27 Thread Jiri Pirko
Sun, May 27, 2018 at 08:48:41AM CEST, ido...@mellanox.com wrote: >From: Petr Machata > >VLAN 1 is internally used for untagged traffic. Prevent creation of >explicit netdevice for that VLAN, because that currently isn't supported >and leads to the NULL pointer dereference

[PATCH net] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-05-27 Thread Ido Schimmel
From: Petr Machata VLAN 1 is internally used for untagged traffic. Prevent creation of explicit netdevice for that VLAN, because that currently isn't supported and leads to the NULL pointer dereference cited below. Fix by preventing creation of VLAN devices with VID of 1