Re: [PATCH net] net: Check for fullsock in sock_i_uid()

2016-11-03 Thread Lorenzo Colitti
On Thu, Nov 3, 2016 at 2:18 AM, Eric Dumazet wrote: > Lorenzo, have'nt you already fixed all these bugs ? Not yet. There's still a fair bit of out-of-tree code left. Other than per-UID routing, xt_qtaguid is the big one, but there's also xt_quota2 and xt_idletimer. to

Re: [PATCH net] net: Check for fullsock in sock_i_uid()

2016-11-02 Thread Eric Dumazet
On Wed, 2016-11-02 at 11:05 -0600, subas...@codeaurora.org wrote: > > This would be a bug in the caller. > > > > Can you give us the complete stack trace leading to the problem you > > had ? > > > > Thanks ! > > Thanks Eric for the clarification. In that case, the bug is in the > IDLETIMER

Re: [PATCH net] net: Check for fullsock in sock_i_uid()

2016-11-02 Thread subashab
This would be a bug in the caller. Can you give us the complete stack trace leading to the problem you had ? Thanks ! Thanks Eric for the clarification. In that case, the bug is in the IDLETIMER target in Android kernel.

Re: [PATCH net] net: Check for fullsock in sock_i_uid()

2016-11-02 Thread Eric Dumazet
On Tue, 2016-11-01 at 23:27 -0600, Subash Abhinov Kasiviswanathan wrote: > sock_i_uid() acquires the sk_callback_lock which does not exist > for sockets in TCP_NEW_SYN_RECV state. This results in errors > showing up as spinlock bad magic. > > Signed-off-by: Subash Abhinov Kasiviswanathan

[PATCH net] net: Check for fullsock in sock_i_uid()

2016-11-01 Thread Subash Abhinov Kasiviswanathan
sock_i_uid() acquires the sk_callback_lock which does not exist for sockets in TCP_NEW_SYN_RECV state. This results in errors showing up as spinlock bad magic. Signed-off-by: Subash Abhinov Kasiviswanathan Cc: Eric Dumazet --- net/core/sock.c | 5