Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.

2018-09-21 Thread David Miller
From: Lorenzo Colitti Date: Fri, 21 Sep 2018 18:46:25 +0800 > Would you take a patch to add a one-line comment saying that this is > the way it is for backwards compatibility? If that comment were there > anyone else who finds this will not spend time debugging it and > immediately know what's go

Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.

2018-09-21 Thread Lorenzo Colitti
On Fri, Sep 14, 2018 at 11:30 PM David Miller wrote: > Unfortunately I think we are stuck with how things are now. > > Indisputably, your patch breaks userland components that have > workarounds in order to work with existing kernels. [...] > I cannot apply this, sorry. Understood. We're about t

Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.

2018-09-14 Thread David Miller
From: Lorenzo Colitti Date: Fri, 14 Sep 2018 15:25:53 +0900 > Since its inception, udp_dump_one had has a bug where userspace > needs to swap src and dst addresses and ports in order to find > the socket it wants. > > This is because udp_dump_one misuses __udp[46]_lib_lookup by > passing the sou

[PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.

2018-09-13 Thread Lorenzo Colitti
Since its inception, udp_dump_one had has a bug where userspace needs to swap src and dst addresses and ports in order to find the socket it wants. This is because udp_dump_one misuses __udp[46]_lib_lookup by passing the source address as the source address argument. Unfortunately, those functions