Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-31 Thread Marco Berizzi
> Il 26 ottobre 2018 alle 20.19 Cong Wang ha scritto: > > On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi wrote: > > > Apologies for bothering you again. > > I applied your patch to 4.19, but after issuing this > > command: > > > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc defa

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Cong Wang
On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi wrote: > Apologies for bothering you again. > I applied your patch to 4.19, but after issuing this > command: > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1 (10.81.104.1)

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Jiri Pirko
Fri, Oct 26, 2018 at 06:02:01PM CEST, dsah...@gmail.com wrote: >On 10/25/18 12:31 AM, Jiri Pirko wrote: >> Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote: >>> From: David Ahern >>> >>> Marco reported an error with hfsc: >>> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfs

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread David Ahern
On 10/25/18 12:31 AM, Jiri Pirko wrote: > Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote: >> From: David Ahern >> >> Marco reported an error with hfsc: >> root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 >> Error: Attribute failed policy validation. >> >> Appar

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread David Ahern
On 10/26/18 5:34 AM, Marco Berizzi wrote: > Apologies for bothering you again. > I applied your patch to 4.19, but after issuing this > command: > > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > root@Calimero:~# ping 10.81.104.1 > PING 10.81.104.1 (10.81.104.1) 56(84) byt

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-26 Thread Marco Berizzi
> Il 24 ottobre 2018 alle 17.32 David Ahern ha scritto: > net/sched/sch_api.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 3dc0acf54245..be7cd140b2a3 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -1309,7 +1309,6 @

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-24 Thread Jiri Pirko
Wed, Oct 24, 2018 at 05:32:49PM CEST, dsah...@kernel.org wrote: >From: David Ahern > >Marco reported an error with hfsc: >root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 >Error: Attribute failed policy validation. > >Apparently a few implementations pass TCA_OPTIONS as a bina

Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-24 Thread David Miller
From: David Ahern Date: Wed, 24 Oct 2018 08:32:49 -0700 > From: David Ahern > > Marco reported an error with hfsc: > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 > Error: Attribute failed policy validation. > > Apparently a few implementations pass TCA_OPTIONS as a bin

[PATCH net] net: sched: Remove TCA_OPTIONS from policy

2018-10-24 Thread David Ahern
From: David Ahern Marco reported an error with hfsc: root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 Error: Attribute failed policy validation. Apparently a few implementations pass TCA_OPTIONS as a binary instead of nested attribute, so drop TCA_OPTIONS from the policy. F