Re: [PATCH net] net_sched: gen_estimator: fix broken estimators based on percpu stats

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 19:36 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > pfifo_fast got percpu stats lately, uncovering a bug I introduced last > year in linux-4.10. > > I missed the fact that we have to clear our temporary storage > before calling __gnet_stats_copy_basic() in the case of

[PATCH net] net_sched: gen_estimator: fix broken estimators based on percpu stats

2018-02-22 Thread Eric Dumazet
From: Eric Dumazet pfifo_fast got percpu stats lately, uncovering a bug I introduced last year in linux-4.10. I missed the fact that we have to clear our temporary storage before calling __gnet_stats_copy_basic() in the case of percpu stats. Without this fix, rate estimators (tc qd replace dev