Re: [PATCH net] nfp: double free on error in probe

2017-08-29 Thread David Miller
From: Dan Carpenter Date: Tue, 29 Aug 2017 22:15:16 +0300 > Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions > call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free > should be done from the probe function because it's allocated there so > I have removed the

Re: [PATCH net] nfp: double free on error in probe

2017-08-29 Thread Jakub Kicinski
On Tue, 29 Aug 2017 22:15:16 +0300, Dan Carpenter wrote: > Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions > call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free > should be done from the probe function because it's allocated there so > I have removed the cal

[PATCH net] nfp: double free on error in probe

2017-08-29 Thread Dan Carpenter
Both the nfp_net_pf_app_start() and the nfp_net_pci_probe() functions call nfp_net_pf_app_stop_ctrl(pf) so there is a double free. The free should be done from the probe function because it's allocated there so I have removed the call from nfp_net_pf_app_start(). Fixes: 02082701b974 ("nfp: create