Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

From: Eric Dumazet Date: Mon, 28 Nov 2016 10:17:23 -0800 > It appears that Eli changelog was not very precise, because his bug was > because of XFRM being involved. > > xfrm_output() -> xfrm_output_gso() -> skb_gso_segment() > > So XFRM calls skb_gso_segment() before

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

From: Eric Dumazet Date: Mon, 28 Nov 2016 10:32:15 -0800 > On Mon, 2016-11-28 at 10:17 -0800, Eric Dumazet wrote: > >> I was referring to Stephen bug report. >> >> It appears that Eli changelog was not very precise, because his bug was >> because of XFRM being involved.

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

On Mon, 2016-11-28 at 10:17 -0800, Eric Dumazet wrote: > I was referring to Stephen bug report. > > It appears that Eli changelog was not very precise, because his bug was > because of XFRM being involved. > > xfrm_output() -> xfrm_output_gso() -> skb_gso_segment() > > So XFRM calls

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

On Mon, 2016-11-28 at 13:01 -0500, David Miller wrote: > Hmmm, ip6_finish_output2() also does a proper assignment of skb->protocol, > therefore why was commit ae148b085876fa771d9ef2c05f85d4b4bf09ce0d > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()") > necessary at all? I was

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

From: Eric Dumazet Date: Mon, 28 Nov 2016 09:34:27 -0800 > On Mon, 2016-11-28 at 08:53 -0800, Eric Dumazet wrote: >> On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote: >> > From: Stephen Rothwell >> > Date: Sun, 27 Nov 2016 13:04:00 +1100 >> >

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

On Mon, Nov 28, 2016 at 8:53 AM, Eric Dumazet wrote: > On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote: >> From: Stephen Rothwell >> Date: Sun, 27 Nov 2016 13:04:00 +1100 >> >> > [Just for Dave's information] >> > >> > On Fri, 25 Nov 2016

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

On Mon, 2016-11-28 at 08:53 -0800, Eric Dumazet wrote: > On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote: > > From: Stephen Rothwell > > Date: Sun, 27 Nov 2016 13:04:00 +1100 > > > > > [Just for Dave's information] > > > > > > On Fri, 25 Nov 2016 13:50:17 +0800 Eli

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

On Mon, 2016-11-28 at 11:47 -0500, David Miller wrote: > From: Stephen Rothwell > Date: Sun, 27 Nov 2016 13:04:00 +1100 > > > [Just for Dave's information] > > > > On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote: > >> > >> Similar to commit

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

From: Stephen Rothwell Date: Sun, 27 Nov 2016 13:04:00 +1100 > [Just for Dave's information] > > On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote: >> >> Similar to commit ae148b085876 >> ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in

Re: [PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

Hi Eli, [Just for Dave's information] On Fri, 25 Nov 2016 13:50:17 +0800 Eli Cooper wrote: > > Similar to commit ae148b085876 > ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"), > sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets >

[PATCH net] sit: Set skb->protocol properly in ipip6_tunnel_xmit()

Similar to commit ae148b085876 ("ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()"), sit tunnels also need to update skb->protocol; otherwise, TSO/GSO packets might not be properly segmented, which causes the packets being dropped. Reported-by: Stephen Rothwell