From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Fri, 06 Jul 2007 15:31:56 +0200
> Rémi Denis-Courmont wrote:
> > On Thursday 05 July 2007 20:25:50 ext James Chapman wrote:
> >
> >>Rémi Denis-Courmont wrote:
> >>
> >>>By the way, couldn't encap_type be remove altogether (using two slightly
> >>>di
Rémi Denis-Courmont wrote:
> On Thursday 05 July 2007 20:25:50 ext James Chapman wrote:
>
>>Rémi Denis-Courmont wrote:
>>
>>>By the way, couldn't encap_type be remove altogether (using two slightly
>>>different callbacks for ESP) from udp_sock?
>>
>>The notion of encap_type is needed for the setso
On Thursday 05 July 2007 20:25:50 ext James Chapman wrote:
> Rémi Denis-Courmont wrote:
> > By the way, couldn't encap_type be remove altogether (using two slightly
> > different callbacks for ESP) from udp_sock?
>
> The notion of encap_type is needed for the setsockopt call so it would
> have to s
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 05 Jul 2007 18:45:02 +0200
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new encap_rcv
> > funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
> > funcptr, which allows us to move the XFRM e
Rémi Denis-Courmont wrote:
By the way, couldn't encap_type be remove altogether (using two slightly
different callbacks for ESP) from udp_sock?
The notion of encap_type is needed for the setsockopt call so it would
have to stay in the API. If it were removed from udp_sock, getsockopt
would h
Le jeudi 5 juillet 2007, vous avez écrit :
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new
> > encap_rcv funcptr was added to struct udp_sock. Have XFRM use the
> > new encap_rcv funcptr, which allows us to move the XFRM encap code
> > from udp.c into xfrm4_in
James Chapman wrote:
> This cleanup fell out after adding L2TP support where a new encap_rcv
> funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
> funcptr, which allows us to move the XFRM encap code from udp.c into
> xfrm4_input.c.
>
> Make xfrm4_rcv_encap() static since it is
This cleanup fell out after adding L2TP support where a new encap_rcv
funcptr was added to struct udp_sock. Have XFRM use the new encap_rcv
funcptr, which allows us to move the XFRM encap code from udp.c into
xfrm4_input.c.
Make xfrm4_rcv_encap() static since it is no longer called externally.
Si
