Re: [PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread David Ahern
On 4/11/17 8:43 AM, Alexander Alemayhu wrote: > On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote: >> listing each program is not a sustainable way to do this. It would be >> simpler to put build targets into a build directory and then ignore the >> build directory. > Agreed. It has

Re: [PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread Alexander Alemayhu
On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote: > > listing each program is not a sustainable way to do this. It would be > simpler to put build targets into a build directory and then ignore the > build directory. Agreed. It has probably been raised before, but if no one else does

Re: [PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread David Ahern
On 4/11/17 6:14 AM, Alexander Alemayhu wrote: > On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote: >> >> Good point, we should also add '*.o' in that case for the >> TEST_GEN_FILES specified objs that clang generates. > > Think that is covered by other files but added. Would it be >

Re: [PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread Alexander Alemayhu
On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote: > > Good point, we should also add '*.o' in that case for the > TEST_GEN_FILES specified objs that clang generates. Think that is covered by other files but added. Would it be okay to ignore all the generated files, like the below?

Re: [PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread Daniel Borkmann
On 04/11/2017 01:35 PM, Alexander Alemayhu wrote: Signed-off-by: Alexander Alemayhu --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index

[PATCH net-next] bpf: add test_progs to .gitignore

2017-04-11 Thread Alexander Alemayhu
Signed-off-by: Alexander Alemayhu --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index 541d9d7fad5a..2fe8766e204f 100644 ---