Re: [PATCH net-next] mpls: support for dead routes

2015-11-03 Thread roopa
Thanks fixed in v3. On 11/2/15, 11:11 PM, Julia Lawall wrote: > Please check on what was intended. > > julia > > On Tue, 3 Nov 2015, kbuild test robot wrote: > >> CC: kbuild-...@01.org >> In-Reply-To: <1446498529-50275-1-git-send-email-ro...@cumulusnetworks.com> >> TO: Roopa Prabhu >> CC: ebied..

Re: [PATCH net-next] mpls: support for dead routes

2015-11-02 Thread Julia Lawall
Please check on what was intended. julia On Tue, 3 Nov 2015, kbuild test robot wrote: > CC: kbuild-...@01.org > In-Reply-To: <1446498529-50275-1-git-send-email-ro...@cumulusnetworks.com> > TO: Roopa Prabhu > CC: ebied...@xmission.com, rshea...@brocade.com, da...@davemloft.net, > netdev@vger.ke

Re: [PATCH net-next] mpls: support for dead routes

2015-11-02 Thread David Miller
From: Roopa Prabhu Date: Mon, 2 Nov 2015 13:08:49 -0800 > + if ((nh->nh_flags & RTNH_F_DEAD) || > + (nh->nh_flags & RTNH_F_LINKDOWN)) > + continue; A single "& (RTNH_F_DEAD | RTNH_F_LINKDOWN)" is more efficient and more canonical. > + if ((nh

[PATCH net-next] mpls: support for dead routes

2015-11-02 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection Signed-off-by: Roopa Prabhu --- RFC to v1: Addressed a few comments from Eric and Robert: - remove support for