Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Alexander Duyck
On 11/03/2015 02:11 PM, Jarod Wilson wrote: Alexander Duyck wrote: On 11/03/2015 12:36 PM, Jarod Wilson wrote: With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly a

Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Jarod Wilson
Alexander Duyck wrote: On 11/03/2015 12:36 PM, Jarod Wilson wrote: With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This cu

Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Jarod Wilson
Michal Kubecek wrote: On Tue, Nov 03, 2015 at 03:36:57PM -0500, Jarod Wilson wrote: With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled

Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Michal Kubecek
On Tue, Nov 03, 2015 at 03:36:57PM -0500, Jarod Wilson wrote: > With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as > well. This cu

Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Nikolay Aleksandrov
On 11/03/2015 09:36 PM, Jarod Wilson wrote: > With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as > well. This currently happens, b

Re: [PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Alexander Duyck
On 11/03/2015 12:36 PM, Jarod Wilson wrote: With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This currently happens, because

[PATCH net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Jarod Wilson
With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This currently happens, because we exit __netdev_update_features() when we se