Re: [PATCH net-next] net: Make RX-FCS and LRO mutually exclusive

2018-03-05 Thread Gal Pressman
On 05-Mar-18 17:27, David Miller wrote: > From: Gal Pressman > Date: Sun, 4 Mar 2018 14:12:04 +0200 > >> LRO and RX-FCS offloads cannot be enabled at the same time since it is >> not clear what should happen to the FCS of each coalesced packet. >> The FCS is not really part of the TCP payload, h

Re: [PATCH net-next] net: Make RX-FCS and LRO mutually exclusive

2018-03-05 Thread David Miller
From: Gal Pressman Date: Sun, 4 Mar 2018 14:12:04 +0200 > LRO and RX-FCS offloads cannot be enabled at the same time since it is > not clear what should happen to the FCS of each coalesced packet. > The FCS is not really part of the TCP payload, hence cannot be merged > into one big packet. On t

[PATCH net-next] net: Make RX-FCS and LRO mutually exclusive

2018-03-04 Thread Gal Pressman
LRO and RX-FCS offloads cannot be enabled at the same time since it is not clear what should happen to the FCS of each coalesced packet. The FCS is not really part of the TCP payload, hence cannot be merged into one big packet. On the other hand, providing one big LRO packet with one FCS contradict