Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-05 Thread Florian Fainelli
On 02/05/2017 08:52 AM, Andrew Lunn wrote: >>> +static irqreturn_t mv88e6xxx_g2_watchdog_thread_fn(int irq, void *dev_id) >>> +{ >>> + u16 reg; >>> + >>> + struct mv88e6xxx_chip *chip = dev_id; >>> + >>> + mv88e6xxx_g2_read(chip, GLOBAL2_WDOG_CONTROL, ); >>> + >>> + dev_info(chip->dev,

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-05 Thread Andrew Lunn
> > +static irqreturn_t mv88e6xxx_g2_watchdog_thread_fn(int irq, void *dev_id) > > +{ > > + u16 reg; > > + > > + struct mv88e6xxx_chip *chip = dev_id; > > + > > + mv88e6xxx_g2_read(chip, GLOBAL2_WDOG_CONTROL, ); > > + > > + dev_info(chip->dev, "Watchdog event: %04x", reg); > > Should this

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-04 Thread Florian Fainelli
Le 02/04/17 à 12:38, Andrew Lunn a écrit : > The switch contains a watchdog looking for issues with the internal > gubbins of the switch. Hook the interrupt the watchdog triggers and > log the value of the control register indicating why the watchdog > fired. The watchdog can only be cleared with

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-04 Thread Andrew Lunn
On Sat, Feb 04, 2017 at 09:38:54PM +0100, Andrew Lunn wrote: > The switch contains a watchdog looking for issues with the internal > gubbins of the switch. Hook the interrupt the watchdog triggers and > log the value of the control register indicating why the watchdog > fired. The watchdog can

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-04 Thread Vivien Didelot
Andrew Lunn writes: > The switch contains a watchdog looking for issues with the internal > gubbins of the switch. Hook the interrupt the watchdog triggers and > log the value of the control register indicating why the watchdog > fired. The watchdog can only be cleared with a

[PATCH net-next] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-04 Thread Andrew Lunn
The switch contains a watchdog looking for issues with the internal gubbins of the switch. Hook the interrupt the watchdog triggers and log the value of the control register indicating why the watchdog fired. The watchdog can only be cleared with a switch reset, which will destroy the current