Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread Simon Horman
On Tue, Apr 18, 2017 at 08:09:08PM +0200, Hannes Frederic Sowa wrote: > > > On Tue, Apr 18, 2017, at 17:16, David Miller wrote: > > From: Simon Horman > > Date: Tue, 18 Apr 2017 17:09:04 +0900 > > > > > On Wed, Mar 08, 2017 at 11:22:01AM -0800, Eric Dumazet wrote: >

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread Hannes Frederic Sowa
On Tue, Apr 18, 2017, at 17:16, David Miller wrote: > From: Simon Horman > Date: Tue, 18 Apr 2017 17:09:04 +0900 > > > On Wed, Mar 08, 2017 at 11:22:01AM -0800, Eric Dumazet wrote: > >> On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: > >> >

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread David Miller
From: Simon Horman Date: Tue, 18 Apr 2017 17:09:04 +0900 > On Wed, Mar 08, 2017 at 11:22:01AM -0800, Eric Dumazet wrote: >> On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: >> > On 2017-03-08 11:40, Eric Dumazet wrote: >> > > Well, this

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-04-18 Thread Simon Horman
On Wed, Mar 08, 2017 at 11:22:01AM -0800, Eric Dumazet wrote: > On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: > > On 2017-03-08 11:40, Eric Dumazet wrote: > > > Well, this 'optimization' actually hurts when UDP sockets are not > > > connected, since this adds an extra

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-03-08 Thread Eric Dumazet
On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: > On 2017-03-08 11:40, Eric Dumazet wrote: > > Well, this 'optimization' actually hurts when UDP sockets are not > > connected, since this adds an extra cache line miss per incoming > > packet. > > > > (DNS servers for

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-03-08 Thread Subash Abhinov Kasiviswanathan
On 2017-03-08 11:40, Eric Dumazet wrote: Well, this 'optimization' actually hurts when UDP sockets are not connected, since this adds an extra cache line miss per incoming packet. (DNS servers for example) Hi Eric Thanks for your comments. Would it be preferable to disable early demux for

[PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-03-08 Thread Subash Abhinov Kasiviswanathan
While running a single stream UDPv6 test, we observed that amount of CPU spent in NET_RX softirq was much greater than UDPv4 for an equivalent receive rate. The test here was run on an ARM64 based Android system. On further analysis with perf, we found that UDPv6 was spending significant time in

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

2017-03-08 Thread Eric Dumazet
On Wed, 2017-03-08 at 11:24 -0700, Subash Abhinov Kasiviswanathan wrote: > While running a single stream UDPv6 test, we observed that amount > of CPU spent in NET_RX softirq was much greater than UDPv4 for an > equivalent receive rate. The test here was run on an ARM64 based > Android system. On