Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-10 Thread David Miller
From: Andrew Lunn Date: Tue, 9 Jan 2018 22:42:09 +0100 > The internal PHYs in the mv88e6390 switch have a temperature sensor. > It uses a different register layout to other PHY currently supported. > It also has an errata, in that some reads of the sensor result in bad > values. So a number of r

Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-10 Thread Florian Fainelli
On 01/10/2018 06:05 AM, Andrew Lunn wrote: +static int m88e6390_hwmon_probe(struct phy_device *phydev) +{ + return marvell_hwmon_probe(phydev, &m88e6390_hwmon_chip_info); +} #else static int m88e1121_hwmon_probe(struct phy_device *phydev) { @@ -1794,6 +19

Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-10 Thread Andrew Lunn
> > > +static int m88e6390_hwmon_probe(struct phy_device *phydev) > > > +{ > > > + return marvell_hwmon_probe(phydev, &m88e6390_hwmon_chip_info); > > > +} > > > #else > > > static int m88e1121_hwmon_probe(struct phy_device *phydev) > > > { > > > @@ -1794,6 +1927,11 @@ static int m88e1510_hwmon_p

Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-10 Thread Andrew Lunn
On Tue, Jan 09, 2018 at 04:14:44PM -0800, Florian Fainelli wrote: > On 01/09/2018 01:42 PM, Andrew Lunn wrote: > > The internal PHYs in the mv88e6390 switch have a temperature sensor. > > It uses a different register layout to other PHY currently supported. > > It also has an errata, in that some r

Re: [PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-09 Thread Florian Fainelli
On 01/09/2018 01:42 PM, Andrew Lunn wrote: > The internal PHYs in the mv88e6390 switch have a temperature sensor. > It uses a different register layout to other PHY currently supported. > It also has an errata, in that some reads of the sensor result in bad > values. So a number of reads need to be

[PATCH net-next] net: phy: marvell: mv88e6390 temperature sensor reading

2018-01-09 Thread Andrew Lunn
The internal PHYs in the mv88e6390 switch have a temperature sensor. It uses a different register layout to other PHY currently supported. It also has an errata, in that some reads of the sensor result in bad values. So a number of reads need to be made, and the average taken. Signed-off-by: Andre