Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-24 Thread Tariq Toukan
On 24/07/2018 12:00 AM, David Miller wrote: From: Cong Wang Date: Mon, 23 Jul 2018 13:37:22 -0700 On Sun, Jul 22, 2018 at 12:29 AM Tariq Toukan wrote: On 19/07/2018 8:21 PM, Cong Wang wrote: On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan wrote: --- a/net/core/dev_ioctl.c +++

Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-23 Thread David Miller
From: Cong Wang Date: Mon, 23 Jul 2018 13:37:22 -0700 > On Sun, Jul 22, 2018 at 12:29 AM Tariq Toukan wrote: >> >> >> >> On 19/07/2018 8:21 PM, Cong Wang wrote: >> > On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan wrote: >> >> --- a/net/core/dev_ioctl.c >> >> +++ b/net/core/dev_ioctl.c >> >> @@

Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-23 Thread Cong Wang
On Sun, Jul 22, 2018 at 12:29 AM Tariq Toukan wrote: > > > > On 19/07/2018 8:21 PM, Cong Wang wrote: > > On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan wrote: > >> --- a/net/core/dev_ioctl.c > >> +++ b/net/core/dev_ioctl.c > >> @@ -282,14 +282,7 @@ static int dev_ifsioc(struct net *net, struct

Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-22 Thread Tariq Toukan
On 19/07/2018 8:21 PM, Cong Wang wrote: On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan wrote: --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -282,14 +282,7 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, unsigned int cmd) return dev_mc_del_global(dev,

Re: [PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-19 Thread Cong Wang
On Thu, Jul 19, 2018 at 7:50 AM Tariq Toukan wrote: > --- a/net/core/dev_ioctl.c > +++ b/net/core/dev_ioctl.c > @@ -282,14 +282,7 @@ static int dev_ifsioc(struct net *net, struct ifreq > *ifr, unsigned int cmd) > return dev_mc_del_global(dev, ifr->ifr_hwaddr.sa_data); > >

[PATCH net-next] net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc

2018-07-19 Thread Tariq Toukan
The cited patch added a call to dev_change_tx_queue_len in SIOCSIFTXQLEN case. This obsoletes the checks done before the function call. Remove them here. Fixes: 3f76df198288 ("net: use dev_change_tx_queue_len() for SIOCSIFTXQLEN") Signed-off-by: Tariq Toukan Reviewed-by: Eran Ben Elisha Cc: