On 11/25/2018 07:52 PM, David Miller wrote:
>
> I fixed up the build in your original patch and am about to push that
> out.
Thanks David, sorry for this, I should have compiled the damn thing :/
From: Eric Dumazet
Date: Sun, 25 Nov 2018 15:37:43 -0800
> On Sun, Nov 25, 2018 at 10:29 AM David Miller wrote:
>>
>> From: Eric Dumazet
>> Date: Sun, 25 Nov 2018 08:26:23 -0800
>>
>> > I do not see how one can effectively use skb_insert() without holding
>> > some kind of lock. Otherwise other
On Sun, Nov 25, 2018 at 10:29 AM David Miller wrote:
>
> From: Eric Dumazet
> Date: Sun, 25 Nov 2018 08:26:23 -0800
>
> > I do not see how one can effectively use skb_insert() without holding
> > some kind of lock. Otherwise other cpus could have changed the list
> > right before we have a chance
Hi Eric,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-remove-unsafe-skb_insert/20181126-061342
config: x86_64-randconfig-x009-201847 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1
From: Eric Dumazet
Date: Sun, 25 Nov 2018 08:26:23 -0800
> I do not see how one can effectively use skb_insert() without holding
> some kind of lock. Otherwise other cpus could have changed the list
> right before we have a chance of acquiring list->lock.
>
> Only existing user is in drivers/inf
I do not see how one can effectively use skb_insert() without holding
some kind of lock. Otherwise other cpus could have changed the list
right before we have a chance of acquiring list->lock.
Only existing user is in drivers/infiniband/hw/nes/nes_mgt.c and this
one probably meant to use __skb_ins
