Re: [PATCH net-next] net_sched: act_bpf: remove spinlock in fast path

2015-08-04 Thread Alexei Starovoitov
On 8/4/15 1:55 AM, Daniel Borkmann wrote: Okay, what happens however, when we have an action attached to a classifier and do a replace on that action, meaning one CPU is still executing the filter inside tcf_bpf(), while another one is already running tcf_bpf_cfg_cleanup() on that prog? Afaik, th

Re: [PATCH net-next] net_sched: act_bpf: remove spinlock in fast path

2015-08-04 Thread Daniel Borkmann
On 08/04/2015 07:09 AM, Alexei Starovoitov wrote: Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing. Also similar to gact/mirred there is a race between prog->filter and prog->tcf_action. Meaning that the program being replaced may use previous default action if it hap

[PATCH net-next] net_sched: act_bpf: remove spinlock in fast path

2015-08-03 Thread Alexei Starovoitov
Similar to act_gact/act_mirred, act_bpf can be lockless in packet processing. Also similar to gact/mirred there is a race between prog->filter and prog->tcf_action. Meaning that the program being replaced may use previous default action if it happened to return TC_ACT_UNSPEC. act_mirred race betwe