Re: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Thu, 7 Dec 2017 17:56:37 +0900, Prashant Bhole wrote: > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote: > > > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > > > > > On Thu, 7 Dec 2017 10:02:13

RE: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote: > > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > > > On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote: > > > > - Handled debugfs_create_dir fa

Re: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-06 Thread Jakub Kicinski
On Thu, 7 Dec 2017 13:10:39 +0900, Prashant Bhole wrote: > > From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > > > On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote: > > > - Handled debugfs_create_dir failure in nsim_init() > > > - Fixed return value of nsim_module_init() whe

RE: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-06 Thread Prashant Bhole
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote: > > - Handled debugfs_create_dir failure in nsim_init() > > - Fixed return value of nsim_module_init() when debugfs_create_dir > > fails > > > > Signed-off-by: Prashant Bhole

Re: [PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-06 Thread Jakub Kicinski
On Thu, 7 Dec 2017 10:02:13 +0900, Prashant Bhole wrote: > - Handled debugfs_create_dir failure in nsim_init() > - Fixed return value of nsim_module_init() when debugfs_create_dir fails > > Signed-off-by: Prashant Bhole Why? Failing to expose the state via DebugFS is not fatal to the driver.

[PATCH net-next] netdevsim: check return value of debugfs_create_dir

2017-12-06 Thread Prashant Bhole
- Handled debugfs_create_dir failure in nsim_init() - Fixed return value of nsim_module_init() when debugfs_create_dir fails Signed-off-by: Prashant Bhole --- drivers/net/netdevsim/netdev.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/netdev