Re: [rds-devel] [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread David Miller
From: Sowmini Varadhan Date: Tue, 26 Jun 2018 12:28:22 -0400 > On (06/26/18 10:53), Sowmini Varadhan wrote: >> Date: Tue, 26 Jun 2018 10:53:23 -0400 >> From: Sowmini Varadhan >> To: David Miller >> Cc: netdev@vger.kernel.org, rds-de...@oss.oracle.com >> Subject: Re: [rds-devel] [PATCH

Re: [rds-devel] [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Sowmini Varadhan
On (06/26/18 10:53), Sowmini Varadhan wrote: > Date: Tue, 26 Jun 2018 10:53:23 -0400 > From: Sowmini Varadhan > To: David Miller > Cc: netdev@vger.kernel.org, rds-de...@oss.oracle.com > Subject: Re: [rds-devel] [PATCH net-next] rds: clean up loopback > > and just to add, the fix itself is

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Dmitry Vyukov
On Tue, Jun 26, 2018 at 5:04 PM, Sowmini Varadhan wrote: > On (06/26/18 16:48), Dmitry Vyukov wrote: >> it probably hit the race by a pure luck of the large program, but then >> never had the same luck when tried to remove any syscalls. >> So it can make sense to submit several test requests to

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Sowmini Varadhan
On (06/26/18 16:48), Dmitry Vyukov wrote: > it probably hit the race by a pure luck of the large program, but then > never had the same luck when tried to remove any syscalls. > So it can make sense to submit several test requests to get more testing. How does one submit test requests by email?

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Sowmini Varadhan
On (06/26/18 23:29), David Miller wrote: > >> > >> Since this probably fixes syzbot reports, this can be targetted > >> at 'net' instead? > > > > that thought occurred to me but I wanted to be conservative and have > > it in net-next first, have the syzkaller-bugs team confirm the > > the fixes

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Dmitry Vyukov
On Tue, Jun 26, 2018 at 4:44 PM, Sowmini Varadhan wrote: > On (06/26/18 23:29), David Miller wrote: >> >> I think there is a way to ask syzbot to test a patch in an >> email. > > Dmitry/syzkaller-bugs, can you clarify? > > This is for the cluster of dup reports like >

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Sowmini Varadhan
On (06/26/18 23:29), David Miller wrote: > > I think there is a way to ask syzbot to test a patch in an > email. Dmitry/syzkaller-bugs, can you clarify? This is for the cluster of dup reports like https://groups.google.com/forum/#!topic/syzkaller-bugs/zBph8Vu-q2U and (most recently)

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread David Miller
From: Sowmini Varadhan Date: Tue, 26 Jun 2018 09:40:43 -0400 > On (06/26/18 22:23), David Miller wrote: >> >> Since this probably fixes syzbot reports, this can be targetted >> at 'net' instead? > > that thought occurred to me but I wanted to be conservative and have > it in net-next first,

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread Sowmini Varadhan
On (06/26/18 22:23), David Miller wrote: > > Since this probably fixes syzbot reports, this can be targetted > at 'net' instead? that thought occurred to me but I wanted to be conservative and have it in net-next first, have the syzkaller-bugs team confirm the the fixes and then backport to

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-26 Thread David Miller
From: Sowmini Varadhan Date: Mon, 25 Jun 2018 06:41:25 -0700 > The RDS core module creates rds_connections based on callbacks > from rds_loop_transport when sending/receiving packets to local > addresses. > > These connections will need to be cleaned up when they are > created from a netns that

Re: [PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-25 Thread Sowmini Varadhan
On (06/25/18 06:41), Sowmini Varadhan wrote: : > Add the changes aligned with the changes from > commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize > netns/module teardown and rds connection/workq management") for > rds_loop_transport FWIW, I am optimistic that this will

[PATCH net-next] rds: clean up loopback rds_connections on netns deletion

2018-06-25 Thread Sowmini Varadhan
The RDS core module creates rds_connections based on callbacks from rds_loop_transport when sending/receiving packets to local addresses. These connections will need to be cleaned up when they are created from a netns that is not init_net, and that netns is deleted. Add the changes aligned with