Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-21 Thread Florian Fainelli
On 03/21/2017 02:04 AM, Niklas Cassel wrote: > On 03/20/2017 11:07 PM, Florian Fainelli wrote: >> >> (snip) >>> >>> However, it is kind of sad that drivers are so inconsistent of what goes >>> in probe and what goes in ndo_open...which is tied together with the >>> whole mess of when certain

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-21 Thread Niklas Cassel
On 03/20/2017 11:07 PM, Florian Fainelli wrote: > > (snip) >> >> However, it is kind of sad that drivers are so inconsistent of what goes >> in probe and what goes in ndo_open...which is tied together with the >> whole mess of when certain ethtool commands work or do not work. > Well, inconsistent

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Florian Fainelli
On 03/20/2017 11:34 AM, Niklas Cassel wrote: > On 03/20/2017 06:43 PM, Florian Fainelli wrote: >> On 03/20/2017 10:29 AM, Niklas Cassel wrote: >>> From: Niklas Cassel >>> >>> It is usually possible to do >>> ethtool -s autoneg on >>> so that you trigger an autoneg before

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Niklas Cassel
On 03/20/2017 06:43 PM, Florian Fainelli wrote: > On 03/20/2017 10:29 AM, Niklas Cassel wrote: >> From: Niklas Cassel >> >> It is usually possible to do >> ethtool -s autoneg on >> so that you trigger an autoneg before calling >> ip link set dev eth0 up > This is

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Joao Pinto
Às 5:44 PM de 3/20/2017, Niklas Cassel escreveu: > On 03/20/2017 06:42 PM, Joao Pinto wrote: >> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >>> From: Niklas Cassel >>> >>> It is usually possible to do >>> ethtool -s autoneg on >>> so that you trigger an autoneg before

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Niklas Cassel
On 03/20/2017 06:42 PM, Joao Pinto wrote: > Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >> From: Niklas Cassel >> >> It is usually possible to do >> ethtool -s autoneg on >> so that you trigger an autoneg before calling >> ip link set dev eth0 up >> >> However, stmmac

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Florian Fainelli
On 03/20/2017 10:29 AM, Niklas Cassel wrote: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up This is completely driver specific and there is no guarantee for this to

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Joao Pinto
Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up > > However, stmmac returns -EBUSY if !netif_running. > The only

[PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

2017-03-20 Thread Niklas Cassel
From: Niklas Cassel It is usually possible to do ethtool -s autoneg on so that you trigger an autoneg before calling ip link set dev eth0 up However, stmmac returns -EBUSY if !netif_running. The only reason for this appears to be that stmmac_init_phy is called from