Re: [PATCH net-next] switchdev: change BUG_ON to WARN for attr set failure case

2015-06-17 Thread Scott Feldman
On Thu, Jun 11, 2015 at 4:27 PM, David Miller da...@davemloft.net wrote: From: sfel...@gmail.com Date: Thu, 11 Jun 2015 11:20:42 -0700 From: Scott Feldman sfel...@gmail.com This particular BUG_ON condition was checking for attr set err in the COMMIT phase, which isn't expected (it's a

Re: [PATCH net-next] switchdev: change BUG_ON to WARN for attr set failure case

2015-06-11 Thread David Miller
From: sfel...@gmail.com Date: Thu, 11 Jun 2015 11:20:42 -0700 From: Scott Feldman sfel...@gmail.com This particular BUG_ON condition was checking for attr set err in the COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is OK but COMMIT fails). But BUG_ON() is too

[PATCH net-next] switchdev: change BUG_ON to WARN for attr set failure case

2015-06-11 Thread sfeldma
From: Scott Feldman sfel...@gmail.com This particular BUG_ON condition was checking for attr set err in the COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is OK but COMMIT fails). But BUG_ON() is too strong for this case, so change to WARN(). BUG_ON() would be warranted