Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Lorenzo Colitti
On Fri, Dec 18, 2015 at 9:14 AM, Eric Dumazet wrote: > Adding support for SYN_RECV request sockets to tcp_abort() > is quite easy after our tcp listener rewrite. I added test coverage for this to our tests. Without this patch, attempting to destroy an SYN_RECV socket

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Eric Dumazet
On Fri, 2015-12-18 at 17:38 +0900, Lorenzo Colitti wrote: > On Fri, Dec 18, 2015 at 9:14 AM, Eric Dumazet wrote: > > Adding support for SYN_RECV request sockets to tcp_abort() > > is quite easy after our tcp listener rewrite. > > I added test coverage for this to our

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread David Miller
From: Eric Dumazet Date: Thu, 17 Dec 2015 16:14:11 -0800 > From: Eric Dumazet > > Adding support for SYN_RECV request sockets to tcp_abort() > is quite easy after our tcp listener rewrite. > > Note that we also need to better handle listeners, or

Re: [PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-18 Thread Lorenzo Colitti
On Fri, Dec 18, 2015 at 9:46 PM, Eric Dumazet wrote: > > Tested-by: Lorenzo Colitti > > I am curious, did you use packetdrill for this ? No, I added this to our existing kernel networking tests: https://android-review.googlesource.com/#/c/187491/

[PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

2015-12-17 Thread Eric Dumazet
From: Eric Dumazet Adding support for SYN_RECV request sockets to tcp_abort() is quite easy after our tcp listener rewrite. Note that we also need to better handle listeners, or we might leak not yet accepted children, because of a missing inet_csk_listen_stop() call.