Re: [PATCH net-next] tcp: do not release socket ownership in tcp_close()

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Oct 2018 23:24:26 -0700 > syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk)); > in tcp_close() > > While a socket is being closed, it is very possible other > threads find it in rtnetlink dump. > > tcp_get_info() will acquire the socket lock for a

[PATCH net-next] tcp: do not release socket ownership in tcp_close()

2018-10-02 Thread Eric Dumazet
syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk)); in tcp_close() While a socket is being closed, it is very possible other threads find it in rtnetlink dump. tcp_get_info() will acquire the socket lock for a short amount of time (slow = lock_sock_fast(sk)/unlock_sock_fast(sk,