Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread David Miller
From: Nicolas Dichtel Date: Thu, 8 Sep 2016 16:31:22 +0200 > Le 08/09/2016 à 13:02, Ilpo Järvinen a écrit : > [snip] >> Acked-By: Ilpo Järvinen > Also nitpicking: the end of the email address is missing ;-) I fixed this up when I applied the patch.

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread David Miller
From: Eric Dumazet Date: Wed, 07 Sep 2016 14:49:28 -0700 > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 > MS

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread Nicolas Dichtel
Le 08/09/2016 à 13:02, Ilpo Järvinen a écrit : [snip] > Acked-By: Ilpo Järvinen Also nitpicking: the end of the email address is missing ;-)

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread Eric Dumazet
On Thu, 2016-09-08 at 14:02 +0300, Ilpo Järvinen wrote: > On Wed, 7 Sep 2016, Eric Dumazet wrote: > While testing, was there any check done for the data that was delivered > in order to ensure that no corruption occured (either by you or Yaogong)? > ...This kind of changes have some potential to

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-08 Thread Ilpo Järvinen
On Wed, 7 Sep 2016, Eric Dumazet wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 > MSS. > > In pre

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-07 Thread Eric Dumazet
On Wed, 2016-09-07 at 15:26 -0700, Stephen Hemminger wrote: > How much does this grow the size of tcp socket structure? This actually shrinks it by 8 bytes, or more on debug kernels where sizeof(spinlock_t) > 4 Before : struct sk_buff_head out_of_order_queue; // At least 24 bytes on 64bit A

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-07 Thread Stephen Hemminger
On Wed, 07 Sep 2016 14:49:28 -0700 Eric Dumazet wrote: > From: Yaogong Wang > > Over the years, TCP BDP has increased by several orders of magnitude, > and some people are considering to reach the 2 Gbytes limit. > > Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 > MSS.

[PATCH net-next] tcp: use an RB tree for ooo receive queue

2016-09-07 Thread Eric Dumazet
From: Yaogong Wang Over the years, TCP BDP has increased by several orders of magnitude, and some people are considering to reach the 2 Gbytes limit. Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000 MSS. In presence of packet losses (or reorders), TCP stores incoming p