Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Guenter Roeck
On Wed, Jan 11, 2017 at 08:16:43PM +0100, Andrew Lunn wrote: > > This makes it kind > > of a circular argument (not that the dsa hwmon driver supports the > > new API anyway, but still). > > Actually, the code i posted does. I didn't just move it, i re-wrote it > to use

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Andrew Lunn
> Are not the *_alarm attributes specifically designed to report such > things? See Documentation/hwmon/sysfs-interface Hi Florian Yes it is, and at the moment, userspace needs to poll it. No need for in interrupt. Andrew

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Andrew Lunn
> This makes it kind > of a circular argument (not that the dsa hwmon driver supports the > new API anyway, but still). Actually, the code i posted does. I didn't just move it, i re-wrote it to use devm_hwmon_device_register_with_info(). Andrew

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Guenter Roeck
On Wed, Jan 11, 2017 at 06:37:41PM +0100, Andrew Lunn wrote: > > However, at the moment, there is no code to enable interrupts for > temperature alarms. I also don't see any need to add such code, since > there is nowhere in HWMON to actively report such an alarm condition. > That is not

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Florian Fainelli
On 01/11/2017 09:37 AM, Andrew Lunn wrote: > On Wed, Jan 11, 2017 at 12:06:11PM -0500, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >>> Marvell Ethernet switches contain temperature sensors. They are inside >>> the embedded PHYs. Move the code into the PHY

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Andrew Lunn
On Wed, Jan 11, 2017 at 12:06:11PM -0500, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Marvell Ethernet switches contain temperature sensors. They are inside > > the embedded PHYs. Move the code into the PHY driver, so that discrete > > PHY drivers also

Re: [PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-11 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > Marvell Ethernet switches contain temperature sensors. They are inside > the embedded PHYs. Move the code into the PHY driver, so that discrete > PHY drivers also export there temperature sensor. This message is not correct. The Marvell Ethernet

[PATCH net-next 0/2] Move hwmon support out of switch and into PHYs.

2017-01-10 Thread Andrew Lunn
Marvell Ethernet switches contain temperature sensors. They are inside the embedded PHYs. Move the code into the PHY driver, so that discrete PHY drivers also export there temperature sensor. Andrew Lunn (2): phy: marvell: Add support for temperature sensor net: dsa: Remove hwmon support