Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-26 Thread Andrew Lunn
> > I just think there might be potential for regressions here. But i've > > not yet looked at the details to really know if there actually is. > > I realize there is still some trepidation about these patches, but it > seems like the only real way to find out if it causes regressions is > to

Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-26 Thread David Miller
From: Andrew Lunn Date: Tue, 24 Oct 2017 11:22:34 +0200 >> In case of probe deferral, you get the full probe function to exit with >> an error, and that usually involves freeing the recently allocated >> dsa_switch instance, and then allocating a new one when probe is >>

Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-24 Thread Andrew Lunn
> In case of probe deferral, you get the full probe function to exit with > an error, and that usually involves freeing the recently allocated > dsa_switch instance, and then allocating a new one when probe is > re-entered, so that should not be a problem. Hi Florian That is the simple case. I

Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-23 Thread Florian Fainelli
On 10/23/2017 02:26 PM, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > >> On Mon, Oct 23, 2017 at 02:17:29PM -0400, Vivien Didelot wrote: >>> DSA has several bitmaps to store the type of ports: cpu_port_mask, >>> dsa_port_mask and enabled_port_mask. But the code is

Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-23 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Mon, Oct 23, 2017 at 02:17:29PM -0400, Vivien Didelot wrote: >> DSA has several bitmaps to store the type of ports: cpu_port_mask, >> dsa_port_mask and enabled_port_mask. But the code is inconsistently >> unmasking them. >> >> The legacy code

Re: [PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-23 Thread Andrew Lunn
On Mon, Oct 23, 2017 at 02:17:29PM -0400, Vivien Didelot wrote: > DSA has several bitmaps to store the type of ports: cpu_port_mask, > dsa_port_mask and enabled_port_mask. But the code is inconsistently > unmasking them. > > The legacy code tries to unmask cpu_port_mask and dsa_port_mask but >

[PATCH net-next 0/2] net: dsa: don't unmask port bitmaps

2017-10-23 Thread Vivien Didelot
DSA has several bitmaps to store the type of ports: cpu_port_mask, dsa_port_mask and enabled_port_mask. But the code is inconsistently unmasking them. The legacy code tries to unmask cpu_port_mask and dsa_port_mask but skips enabled_port_mask. The new bindings unmasks cpu_port_mask and