Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-14 Thread David Miller
From: Tom Herbert Date: Thu, 13 Oct 2016 12:29:46 -0700 > On Thu, Oct 13, 2016 at 12:17 PM, David Miller wrote: >> This socket lookup is very heavy handed, and I realize that you >> need this because we no longer store the encapsulation socket in >> skb->sk these days. >> > I don't quite underst

Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-13 Thread Tom Herbert
On Thu, Oct 13, 2016 at 12:17 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 12 Oct 2016 16:25:42 -0700 > >> Since performing a UDP lookup on every packet might be expensive I >> added a static key check to bypass the lookup if there are no >> sockets with flow_dissect set. I should men

Re: [PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-13 Thread David Miller
From: Tom Herbert Date: Wed, 12 Oct 2016 16:25:42 -0700 > Since performing a UDP lookup on every packet might be expensive I > added a static key check to bypass the lookup if there are no > sockets with flow_dissect set. I should mention that doing the > lookup wasn't particularly a big hit anyw

[PATCH net-next 0/5] udp: Flow dissection for tunnels

2016-10-12 Thread Tom Herbert
Now that we have a means to perform a UDP socket lookup without taking a reference, it is feasible to have flow dissector crack open UDP encapsulated packets. Generally, we would expect that the UDP source port or the flow label in IPv6 would contain enough entropy about the encapsulated flow. Howe