Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/31/2018 8:21 PM, David Ahern wrote: On 3/31/18 9:53 AM, Andrew Lunn wrote: I want to be able to login to a customer and accessing this snapshot without any previous configuration from the user and not asking for enabling the feature and then waiting for a repro...this will help debugging

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/31/18 9:53 AM, Andrew Lunn wrote: >> I want to be able to login to a customer and accessing this snapshot >> without any previous configuration from the user and not asking for >> enabling the feature and then waiting for a repro...this will help >> debugging issues that are hard to

Re: [PATCH net-next 0/9] devlink: Add support for region access

> I want to be able to login to a customer and accessing this snapshot > without any previous configuration from the user and not asking for > enabling the feature and then waiting for a repro...this will help > debugging issues that are hard to reproduce, I don't see any reason > to disable this.

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/31/2018 1:26 AM, David Ahern wrote: On 3/30/18 1:39 PM, Alex Vesker wrote: On 3/30/2018 7:57 PM, David Ahern wrote: On 3/30/18 8:34 AM, Andrew Lunn wrote: And it seems to want contiguous pages. How well does that work after the system has been running for a while and memory is

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/30/18 1:39 PM, Alex Vesker wrote: > > > On 3/30/2018 7:57 PM, David Ahern wrote: >> On 3/30/18 8:34 AM, Andrew Lunn wrote: > And it seems to want contiguous pages. How well does that work after > the system has been running for a while and memory is fragmented? The allocation

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/30/2018 7:57 PM, David Ahern wrote: On 3/30/18 8:34 AM, Andrew Lunn wrote: And it seems to want contiguous pages. How well does that work after the system has been running for a while and memory is fragmented? The allocation can be changed, there is no read need for contiguous pages. It

Re: [PATCH net-next 0/9] devlink: Add support for region access

From: Andrew Lunn Date: Thu, 29 Mar 2018 21:51:54 +0200 > And it seems to want contiguous pages. How well does that work after > the system has been running for a while and memory is fragmented? Indeed this will be a problem.

Re: [PATCH net-next 0/9] devlink: Add support for region access

From: Alex Vesker Date: Fri, 30 Mar 2018 08:28:39 +0300 > On 3/29/2018 10:51 PM, Andrew Lunn wrote: >> Also, i doubt write support will be accepted. That sounds like the >> start of an API to allow a user space driver. > > If this will be an issue we will stay with read

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/30/18 8:34 AM, Andrew Lunn wrote: >>> And it seems to want contiguous pages. How well does that work after >>> the system has been running for a while and memory is fragmented? >> >> The allocation can be changed, there is no read need for contiguous pages. >> It is important to note that we

Re: [PATCH net-next 0/9] devlink: Add support for region access

> >And it seems to want contiguous pages. How well does that work after > >the system has been running for a while and memory is fragmented? > > The allocation can be changed, there is no read need for contiguous pages. > It is important to note that we the amount of snapshots is limited by the >

Re: [PATCH net-next 0/9] devlink: Add support for region access

Fri, Mar 30, 2018 at 11:51:57AM CEST, rahul.lakkire...@chelsio.com wrote: >On Thursday, March 03/29/18, 2018 at 23:53:43 +0530, Andrew Lunn wrote: >> On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: >> > This is a proposal which will allow access to driver defined address >> > regions

Re: [PATCH net-next 0/9] devlink: Add support for region access

Thu, Mar 29, 2018 at 09:51:54PM CEST, and...@lunn.ch wrote: >> >>Show all of the exposed regions with region sizes: >> >>$ devlink region show >> >>pci/:00:05.0/cr-space: size 1048576 snapshot [1 2] >> >So you have 2Mbytes of snapshot data. Is this held in the device, or >> >kernel memory? >>

Re: [PATCH net-next 0/9] devlink: Add support for region access

On Thursday, March 03/29/18, 2018 at 23:53:43 +0530, Andrew Lunn wrote: > On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: > > This is a proposal which will allow access to driver defined address > > regions using devlink. Each device can create its supported address > > regions and

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/29/2018 10:51 PM, Andrew Lunn wrote: Show all of the exposed regions with region sizes: $ devlink region show pci/:00:05.0/cr-space: size 1048576 snapshot [1 2] So you have 2Mbytes of snapshot data. Is this held in the device, or kernel memory? This is allocated in devlink, the

Re: [PATCH net-next 0/9] devlink: Add support for region access

> >>Show all of the exposed regions with region sizes: > >>$ devlink region show > >>pci/:00:05.0/cr-space: size 1048576 snapshot [1 2] > >So you have 2Mbytes of snapshot data. Is this held in the device, or > >kernel memory? > This is allocated in devlink, the maximum number of snapshots is

Re: [PATCH net-next 0/9] devlink: Add support for region access

On 3/29/2018 8:13 PM, Andrew Lunn wrote: On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: This is a proposal which will allow access to driver defined address regions using devlink. Each device can create its supported address regions and register them. A device which exposes a

Re: [PATCH net-next 0/9] devlink: Add support for region access

On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: > This is a proposal which will allow access to driver defined address > regions using devlink. Each device can create its supported address > regions and register them. A device which exposes a region will allow > access to it using

Re: [PATCH net-next 0/9] devlink: Add support for region access

On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: > This is a proposal which will allow access to driver defined address > regions using devlink. Each device can create its supported address > regions and register them. A device which exposes a region will allow > access to it using

[PATCH net-next 0/9] devlink: Add support for region access

This is a proposal which will allow access to driver defined address regions using devlink. Each device can create its supported address regions and register them. A device which exposes a region will allow access to it using devlink. The suggested implementation will allow exposing regions to