Re: [PATCH net-next 01/19] bna: use ether_addr_copy instead of memcpy

2015-06-11 Thread Ivan Vecera
On 06/10/2015 07:57 PM, Joe Perches wrote: On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote: Signed-off-by: Ivan Vecera ivec...@redhat.com Have you verified that all of these are __aligned(2)? I haven't, but you should verify that you have in the commit log. I have checked an alignment

[PATCH net-next 01/19] bna: use ether_addr_copy instead of memcpy

2015-06-10 Thread Ivan Vecera
Signed-off-by: Ivan Vecera ivec...@redhat.com --- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 12 ++-- drivers/net/ethernet/brocade/bna/bnad.c | 14 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c

Re: [PATCH net-next 01/19] bna: use ether_addr_copy instead of memcpy

2015-06-10 Thread Joe Perches
On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote: Signed-off-by: Ivan Vecera ivec...@redhat.com Have you verified that all of these are __aligned(2)? I haven't, but you should verify that you have in the commit log. btw: this use looks odd to me: static int bnad_set_mac_address(struct