Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-04 Thread Jiri Pirko
Thu, Apr 05, 2018 at 01:00:18AM CEST, dsah...@gmail.com wrote: >On 4/4/18 4:59 PM, Jakub Kicinski wrote: >> On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: Jiri, I am not aware of any other API where a driver registers with it yet doesn't want the handler to be called so either

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-04 Thread David Ahern
On 4/4/18 4:59 PM, Jakub Kicinski wrote: > On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: >>> Jiri, I am not aware of any other API where a driver registers with it >>> yet doesn't want the handler to be called so either waits to register >> >> Again, the thing is, this is kind of unusual

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-04 Thread Jakub Kicinski
On Wed, 4 Apr 2018 08:25:11 +0200, Jiri Pirko wrote: > >Jiri, I am not aware of any other API where a driver registers with it > >yet doesn't want the handler to be called so either waits to register > > Again, the thing is, this is kind of unusual because of the reload > thing. FWIW my knee

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-04 Thread Jiri Pirko
Wed, Apr 04, 2018 at 02:47:19AM CEST, dsah...@gmail.com wrote: >On 4/3/18 9:30 AM, Jiri Pirko wrote: >> Tue, Apr 03, 2018 at 04:33:11PM CEST, dsah...@gmail.com wrote: >>> On 4/3/18 1:32 AM, Jiri Pirko wrote: Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: > On 3/29/18 2:33

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread David Ahern
On 4/3/18 9:30 AM, Jiri Pirko wrote: > Tue, Apr 03, 2018 at 04:33:11PM CEST, dsah...@gmail.com wrote: >> On 4/3/18 1:32 AM, Jiri Pirko wrote: >>> Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: On 3/29/18 2:33 PM, Ido Schimmel wrote: > From: Jiri Pirko

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread Jiri Pirko
Tue, Apr 03, 2018 at 04:33:11PM CEST, dsah...@gmail.com wrote: >On 4/3/18 1:32 AM, Jiri Pirko wrote: >> Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >>> On 3/29/18 2:33 PM, Ido Schimmel wrote: From: Jiri Pirko This resolves race during

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread David Ahern
On 4/3/18 1:32 AM, Jiri Pirko wrote: > Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >> On 3/29/18 2:33 PM, Ido Schimmel wrote: >>> From: Jiri Pirko >>> >>> This resolves race during initialization where the resources with >>> ops are registered before driver

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-03 Thread Jiri Pirko
Fri, Mar 30, 2018 at 04:45:50PM CEST, dsah...@gmail.com wrote: >On 3/29/18 2:33 PM, Ido Schimmel wrote: >> From: Jiri Pirko >> >> This resolves race during initialization where the resources with >> ops are registered before driver and the structures used by occ_get >> op is

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-04-01 Thread Ido Schimmel
On Fri, Mar 30, 2018 at 08:45:50AM -0600, David Ahern wrote: > On 3/29/18 2:33 PM, Ido Schimmel wrote: > > From: Jiri Pirko > > > > This resolves race during initialization where the resources with > > ops are registered before driver and the structures used by occ_get > > op

Re: [PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-03-30 Thread David Ahern
On 3/29/18 2:33 PM, Ido Schimmel wrote: > From: Jiri Pirko > > This resolves race during initialization where the resources with > ops are registered before driver and the structures used by occ_get > op is initialized. So keep occ_get callbacks registered only when > all

[PATCH net-next 09/11] devlink: convert occ_get op to separate registration

2018-03-29 Thread Ido Schimmel
From: Jiri Pirko This resolves race during initialization where the resources with ops are registered before driver and the structures used by occ_get op is initialized. So keep occ_get callbacks registered only when all structs are initialized. Signed-off-by: Jiri Pirko