Re: [PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA

2017-07-19 Thread Arkadi Sharshevsky
On 07/18/2017 09:06 PM, Vivien Didelot wrote: > Hi Arkadi, > > Arkadi Sharshevsky writes: > >> +typedef int dsa_fdb_dump_cb_t(const unsigned char *addr, u16 vid, >> + u16 ndm_state, void *data); > > Can I ask you to change u16 ndm_state for bool

Re: [PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA

2017-07-18 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > +typedef int dsa_fdb_dump_cb_t(const unsigned char *addr, u16 vid, > + u16 ndm_state, void *data); Can I ask you to change u16 ndm_state for bool is_static at the same time? Ethernet switches do not need to

[PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA

2017-07-18 Thread Arkadi Sharshevsky
>From all switchdev devices only DSA requires special FDB dump. This is due to lack of ability for syncing the hardware learned FDBs with the bridge. Due to this it is removed from switchdev and moved inside DSA. Signed-off-by: Arkadi Sharshevsky ---