Thanks for all reviews & comments.
- Woojung
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Friday, July 31, 2015 6:19 PM
> To: Woojung Huh - C21699
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 1/1] Microchip's LAN
From:
Date: Thu, 30 Jul 2015 19:45:21 +
> Repost patch of driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit E=
> thernet.
> - remove module param which can be configurable by standard mechanism.
> - remove other module parms except msg_level per review comment.
> - update to handle by
Repost patch of driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit
Ethernet.
- remove module param which can be configurable by standard mechanism.
- remove other module parms except msg_level per review comment.
- update to handle byte swap for statistics structure correctly.
Signed-off-b
p's LAN7800 family USB 2/3 to
> 10/100/1000 Ethernet device driver
>
> From:
> Date: Mon, 27 Jul 2015 19:59:30 +
>
> > +static int lan78xx_read_stats(struct lan78xx_net *dev,
> > + struct lan78xx_statstage *data)
> > +{
>
From:
Date: Mon, 27 Jul 2015 19:59:30 +
> +static int lan78xx_read_stats(struct lan78xx_net *dev,
> + struct lan78xx_statstage *data)
> +{
> + int ret = 0;
> + struct lan78xx_statstage *stats;
> +
> + BUG_ON(!dev);
> + BUG_ON(!data);
> + BUG_ON(si
This patch adds a driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit
Ethernet.
- remove module param which can be configurable by standard mechanism.
- remove other module parms except msg_level per review comment.
Signed-off-by: Woojung Huh
---
drivers/net/usb/Kconfig | 10 +
driver
ip's LAN7800 family USB 2/3 to
> 10/100/1000 Ethernet device driver
>
> From:
> Date: Wed, 22 Jul 2015 19:01:44 +
>
> > - remove module param which can be configurable by standard mechanism.
>
> You still left some unacceptable module parameters in here.
>
From:
Date: Wed, 22 Jul 2015 19:01:44 +
> - remove module param which can be configurable by standard mechanism.
You still left some unacceptable module parameters in here.
The only one which is fine is the debug level setting, that's
it.
There is no way in I'm applying a patch that allows
This patch adds a driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit
Ethernet.
- remove module param which can be configurable by standard mechanism.
Signed-off-by: Woojung Huh
---
drivers/net/usb/Kconfig | 10 +
drivers/net/usb/Makefile |1 +
drivers/net/usb/lan78xx.c | 3587 ++
Thanks.
Will post new patch.
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, July 22, 2015 2:06 PM
> To: Woojung Huh - C21699
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family U
DO not reply to feedback to post a new version of your patch.
Instead, make a new, fresh, patch posting.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David,
> > +static int eee_control = -1;
> > +module_param(eee_control, int, 0444);
> > +MODULE_PARM_DESC(eee_control, "EEPROM default(-1), disable(0) &
> enable(1)");
>
> Please don't add module parameters for things configurable via ethtool and
> other generic, standard, mechanisms.
Per you
From:
Date: Thu, 16 Jul 2015 22:16:05 +
> +static int eee_control = -1;
> +module_param(eee_control, int, 0444);
> +MODULE_PARM_DESC(eee_control, "EEPROM default(-1), disable(0) & enable(1)");
Please don't add module parameters for things configurable via ethtool and
other generic, standard,
(Repost because old post seems to be lost.)
This patch adds a driver for LAN7800 family of
USB 2.0 & USB 3.0 to Gigabit Ethernet.
Signed-off-by: Woojung Huh
---
drivers/net/usb/Kconfig | 10 +
drivers/net/usb/Makefile |1 +
drivers/net/usb/lan78xx.c | 3596 +
14 matches
Mail list logo
