Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

On 3/16/18 9:38 AM, David Miller wrote: > From: David Ahern > Date: Fri, 16 Mar 2018 08:45:10 -0700 > >> On 3/16/18 8:40 AM, David Miller wrote: >>> Hmmm, this actually "accumulates" the flag rather than sets it. >>> >>> Have you thought about what should happen if the cfg has

Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

From: David Ahern Date: Fri, 16 Mar 2018 08:45:10 -0700 > On 3/16/18 8:40 AM, David Miller wrote: >> Hmmm, this actually "accumulates" the flag rather than sets it. >> >> Have you thought about what should happen if the cfg has RTNH_F_ONLINK >> set? > > yes, that's why the

Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

On 3/16/18 8:40 AM, David Miller wrote: > From: David Ahern > Date: Tue, 13 Mar 2018 08:40:09 -0700 > >> For multipath routes the ONLINK flag is specified per nexthop in rtnh_flags >> (as opposed to rtm_flags for unicast routes). Update ip6_route_multipath_add >> to set

Re: [PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

From: David Ahern Date: Tue, 13 Mar 2018 08:40:09 -0700 > For multipath routes the ONLINK flag is specified per nexthop in rtnh_flags > (as opposed to rtm_flags for unicast routes). Update ip6_route_multipath_add > to set fc_flags based on rtnh_flags. > > Fixes: fc1e64e1092f

[PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

For multipath routes the ONLINK flag is specified per nexthop in rtnh_flags (as opposed to rtm_flags for unicast routes). Update ip6_route_multipath_add to set fc_flags based on rtnh_flags. Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag") Signed-off-by: David Ahern