Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-12 Thread Sean Wang
On Tue, 2017-12-12 at 09:24 +0100, Felix Fietkau wrote: > On 2017-12-07 07:06, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port > Shouldn't that be VLAN-unaware/VLAN-aware (in the code as

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-12 Thread Felix Fietkau
On 2017-12-07 07:06, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port Shouldn't that be VLAN-unaware/VLAN-aware (in the code as well)? - Felix

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-11 Thread Sean Wang
Hi, Andrew All sounds reasonable. All will be fixed in the next version. Sean On Thu, 2017-12-07 at 16:24 +0100, Andrew Lunn wrote: > > static void > > +mt7530_port_set_vlan_unware(struct dsa_switch *ds, int port) > > +{ > > + struct mt7530_priv *priv = ds->priv; > > + int i; > >

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-07 Thread Andrew Lunn
> static void > +mt7530_port_set_vlan_unware(struct dsa_switch *ds, int port) > +{ > + struct mt7530_priv *priv = ds->priv; > + int i; > + bool all_user_ports_removed = true; Hi Sean Reverse Christmas tree please. > +static int > +mt7530_vlan_cmd(struct mt7530_priv *priv, enum

[PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-06 Thread sean.wang
From: Sean Wang MT7530 can treat each port as either VLAN-unware port or VLAN-ware port through the implementation of port matrix mode or port security mode on the ingress port, respectively. On one hand, Each port has been acting as the VLAN-unware one whenever the