Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-04 Thread John Crispin
err; > ... > } > > > Nelson Hi Nelson, I think that looks nicer, thanks ! John > > -Original Message- > From: John Crispin [mailto:j...@phrozen.org] > Sent: Tuesday, October 04, 2016 3:17 AM > To: Nelson Chang (張家祥); da...@davemloft.net &g

RE: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-04 Thread Nelson Chang
vemloft.net Cc: n...@openwrt.org; netdev@vger.kernel.org; linux-media...@lists.infradead.org; nelsonch...@gmail.com Subject: Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers Hi Nelson, comments inline On 03/10/2016 09:18, Nelson Chang wrote: > The driver gets th

Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-03 Thread John Crispin
Hi Nelson, comments inline On 03/10/2016 09:18, Nelson Chang wrote: > The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers > in mtk_probe(). > > Signed-off-by: Nelson Chang > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 27

[PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-03 Thread Nelson Chang
The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers in mtk_probe(). Signed-off-by: Nelson Chang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 27 +++ drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 + 2 files