Re: [PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine

2017-02-06 Thread Andrew Lunn
On Mon, Feb 06, 2017 at 03:55:20PM -0800, Florian Fainelli wrote: > Calling phy_read_status() means that we may call into > genphy_read_status() which in turn will use genphy_update_link() which > can make changes to phydev->link outside of the state machine's state > transitions. This is an

[PATCH net-next 1/4] net: mv643xx_eth: Do not clobber PHY link outside of state machine

2017-02-06 Thread Florian Fainelli
Calling phy_read_status() means that we may call into genphy_read_status() which in turn will use genphy_update_link() which can make changes to phydev->link outside of the state machine's state transitions. This is an invalid behavior that is now caught as of 811a919135b9 ("phy state machine: