Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread David Ahern
On 10/15/17 9:59 AM, Ido Schimmel wrote: > On Sun, Oct 15, 2017 at 09:24:07AM -0600, David Ahern wrote: >> On 10/15/17 1:50 AM, Ido Schimmel wrote: >>> On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: ipv6_add_addr is called in process context with rtnl lock held (e.g.,

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread Ido Schimmel
On Sun, Oct 15, 2017 at 09:24:07AM -0600, David Ahern wrote: > On 10/15/17 1:50 AM, Ido Schimmel wrote: > > On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: > >> ipv6_add_addr is called in process context with rtnl lock held > >> (e.g., manual config of an address) or during softirq

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread David Ahern
On 10/15/17 1:50 AM, Ido Schimmel wrote: > On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: >> ipv6_add_addr is called in process context with rtnl lock held >> (e.g., manual config of an address) or during softirq processing >> (e.g., autoconf and address from a router advertisement).

Re: [PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-15 Thread Ido Schimmel
On Fri, Oct 13, 2017 at 04:02:09PM -0700, David Ahern wrote: > ipv6_add_addr is called in process context with rtnl lock held > (e.g., manual config of an address) or during softirq processing > (e.g., autoconf and address from a router advertisement). > > Currently, ipv6_add_addr calls

[PATCH net-next 1/5] ipv6: addrconf: cleanup locking in ipv6_add_addr

2017-10-13 Thread David Ahern
ipv6_add_addr is called in process context with rtnl lock held (e.g., manual config of an address) or during softirq processing (e.g., autoconf and address from a router advertisement). Currently, ipv6_add_addr calls rcu_read_lock_bh shortly after entry and does not call unlock until exit, minus