Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-09 Thread Linus Walleij
On Tue, Dec 5, 2017 at 8:03 PM, Michał Mirosław wrote: > I'm happy to see that my work didn't go to /dev/null after all. > I haven't finished it at the time because the box I had broke down > beyond repair. Ooops that explains why the submission was just haning in

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-06 Thread David Miller
From: Linus Walleij Date: Wed, 6 Dec 2017 14:02:49 +0100 > On Mon, Dec 4, 2017 at 12:21 AM, David Miller wrote: > >>> +static irqreturn_t gemini_port_irq_thread(int irq, void *data) >>> +{ >>> + struct gemini_ethernet_port *port = data; >>> +

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-06 Thread Linus Walleij
On Mon, Dec 4, 2017 at 12:21 AM, David Miller wrote: >> +static irqreturn_t gemini_port_irq_thread(int irq, void *data) >> +{ >> + struct gemini_ethernet_port *port = data; >> + struct gemini_ethernet *geth = port->geth; >> + unsigned long irqmask =

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-05 Thread Michał Mirosław
On Sat, Dec 02, 2017 at 12:06:40PM +0100, Linus Walleij wrote: [...] > The latest v6 incarnation of this driver was written by Michał > Mirosław and submitted for inclusion in 2011. This was the > last post: > https://lwn.net/Articles/437889/ > > DaveM ACKed it at the time: >

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-03 Thread David Miller
From: Linus Walleij Date: Sat, 2 Dec 2017 12:06:40 +0100 > +struct gmac_txq { > + GMAC_TXDESC_T *ring; Please don't create struct based typedef's, express this using a straight "struct gmac_rxdesc_t", and also make it lowercase. Uppercase names are reserved for

[PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-02 Thread Linus Walleij
The Gemini ethernet has been around for years as an out-of-tree patch used with the NAS boxen and routers built on StorLink SL3512 and SL3516, later Storm Semiconductor, later Cortina Systems. These ASICs are still being deployed and brand new off-the-shelf systems using it can easily be acquired.