RE: [PATCH net-next 2/3] nfp: look for firmware image by device serial number and PCI name

2017-07-27 Thread David Laight
From: Jakub Kicinski > Sent: 27 July 2017 10:26 ... > > - use snprintf(). > > To effectively print an integer into an amply sized array? I need to > guarantee that the string will fit otherwise I would request a FW image > with a wrong name. snprintf() would only mask such a bug. Eh? If, for

Re: [PATCH net-next 2/3] nfp: look for firmware image by device serial number and PCI name

2017-07-27 Thread Jakub Kicinski
On Thu, 27 Jul 2017 08:20:22 +, David Laight wrote: > From: Jakub Kicinski > > Sent: 26 July 2017 19:10 > > We generally look up firmware by card type, but that doesn't allow > > users who have more than one card of the same type in their system > > to select firmware per adapter. > > > >

RE: [PATCH net-next 2/3] nfp: look for firmware image by device serial number and PCI name

2017-07-27 Thread David Laight
From: Jakub Kicinski > Sent: 26 July 2017 19:10 > We generally look up firmware by card type, but that doesn't allow > users who have more than one card of the same type in their system > to select firmware per adapter. > > Unfortunately user space firmware helper seems fraught with >

[PATCH net-next 2/3] nfp: look for firmware image by device serial number and PCI name

2017-07-26 Thread Jakub Kicinski
We generally look up firmware by card type, but that doesn't allow users who have more than one card of the same type in their system to select firmware per adapter. Unfortunately user space firmware helper seems fraught with difficulties and to be on its way out. In particular support for