Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
On Thu, 25 Apr 2019 06:30:24 -0700 Eric Dumazet wrote: > On Thu, Apr 25, 2019 at 6:13 AM Bruno Prémont wrote: > > On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: >

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Eric Dumazet
On Thu, Apr 25, 2019 at 6:13 AM Bruno Prémont wrote: > > Hi Eric, > > On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > > Hi Eric, > > > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > > > > > Hi Eric, > > > > > >

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
Hi Eric, On Thu, 25 Apr 2019 09:55:31 +0200 Bruno Prémont wrote: > Hi Eric, > > On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > > > Hi Eric, > > > > > > I'm seeing issues with this patch as well, not as regular as for > > >

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-25 Thread Bruno Prémont
Hi Eric, On Wed, 24 Apr 2019 08:47:27 -0700 Eric Dumazet wrote: > On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > > > Hi Eric, > > > > I'm seeing issues with this patch as well, not as regular as for > > Richard but still (about up to one in 30-50 TCP sessions). > > > > In my case I have

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-24 Thread Eric Dumazet
On Wed, Apr 24, 2019 at 7:51 AM Bruno Prémont wrote: > > Hi Eric, > > I'm seeing issues with this patch as well, not as regular as for > Richard but still (about up to one in 30-50 TCP sessions). > > In my case I have a virtual machine (on VMWare) with this patch where > NGINX as reverse proxy mis

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-24 Thread Bruno Prémont
Hi Eric, I'm seeing issues with this patch as well, not as regular as for Richard but still (about up to one in 30-50 TCP sessions). In my case I have a virtual machine (on VMWare) with this patch where NGINX as reverse proxy misses part (end) of payload from its upstream and times out on the ups

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2019-04-07 Thread richard . purdie
Hi, I've been chasing down why a python test from the python3 testsuite started failing and it seems to point to this kernel change in the networking stack. In kernels beyond commit 4f693b55c3d2d2239b8a0094b518a1e533cf75d5 the test hangs about 90% of the time (I've reproduced with 5.1-rc3, 5.0.7,

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-22 Thread Eric Dumazet
On Thu, Nov 22, 2018 at 10:16 AM Eric Dumazet wrote: > Yes, I was considering properly filtering SACK as a refinement later [1] > but you raise a valid point for alien stacks that are not yet using SACK :/ > > [1] This version of the patch will not aggregate sacks since the > memcmp() on tcp opti

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-22 Thread Eric Dumazet
On Thu, Nov 22, 2018 at 10:01 AM Neal Cardwell wrote: > > On Wed, Nov 21, 2018 at 12:52 PM Eric Dumazet wrote: > > > > In case GRO is not as efficient as it should be or disabled, > > we might have a user thread trapped in __release_sock() while > > softirq handler flood packets up to the point w

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-22 Thread Neal Cardwell
On Wed, Nov 21, 2018 at 12:52 PM Eric Dumazet wrote: > > In case GRO is not as efficient as it should be or disabled, > we might have a user thread trapped in __release_sock() while > softirq handler flood packets up to the point we have to drop. > > This patch balances work done from user thread

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-22 Thread Yuchung Cheng
On Wed, Nov 21, 2018 at 2:40 PM, Eric Dumazet wrote: > > > On 11/21/2018 02:31 PM, Yuchung Cheng wrote: >> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: > >>> + >> Really nice! would it make sense to re-use (some of) the similar >> tcp_try_coalesce()? >> > > Maybe, but it is a bit complex,

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-21 Thread Eric Dumazet
On 11/21/2018 02:31 PM, Yuchung Cheng wrote: > On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: >> + > Really nice! would it make sense to re-use (some of) the similar > tcp_try_coalesce()? > Maybe, but it is a bit complex, since skbs in receive queues (regular or out of order) are accou

Re: [PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-21 Thread Yuchung Cheng
On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: > > In case GRO is not as efficient as it should be or disabled, > we might have a user thread trapped in __release_sock() while > softirq handler flood packets up to the point we have to drop. > > This patch balances work done from user thread

[PATCH net-next 2/3] tcp: implement coalescing on backlog queue

2018-11-21 Thread Eric Dumazet
In case GRO is not as efficient as it should be or disabled, we might have a user thread trapped in __release_sock() while softirq handler flood packets up to the point we have to drop. This patch balances work done from user thread and softirq, to give more chances to __release_sock() to complete