Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

2018-07-30 Thread Wei Wang
On Mon, Jul 30, 2018 at 3:14 PM Stephen Hemminger wrote: > > On Mon, 30 Jul 2018 14:59:09 -0700 > Wei Wang wrote: > > > + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) + > > 7 * nla_total_size(sizeof(u32)) + > > 3 *

Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

2018-07-30 Thread Stephen Hemminger
On Mon, 30 Jul 2018 14:59:09 -0700 Wei Wang wrote: > + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) + > 7 * nla_total_size(sizeof(u32)) + > 3 * nla_total_size(sizeof(u8)), GFP_ATOMIC); This is getting a bit awkward. Maybe use the

[PATCH net-next 2/4] tcp: add data bytes retransmitted stats

2018-07-30 Thread Wei Wang
From: Wei Wang Introduce a new TCP stat to record the number of bytes retransmitted (RFC4898 tcpEStatsPerfOctetsRetrans) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: