Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > >

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jeff Kirsher
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > Per Jesse Brandeburg, e1000e should be using flags for this sort of > thing. > > Littering functional code with device-specific checks is much messier > than > simply checking a flag, and having device-specific init set flags as > needed. >

[PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

2016-07-26 Thread Jarod Wilson
Per Jesse Brandeburg, e1000e should be using flags for this sort of thing. Littering functional code with device-specific checks is much messier than simply checking a flag, and having device-specific init set flags as needed. There are probably a number of other cases in the e1000e code that